Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hiera nginx_mailhosts_defaults like nginx_servers_defaults #1068

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Add hiera nginx_mailhosts_defaults like nginx_servers_defaults #1068

merged 1 commit into from
Apr 11, 2017

Conversation

dol
Copy link
Contributor

@dol dol commented Apr 10, 2017

Set mailhosts default value. This is useful when setting the SSL settings on multiple ports and protocols or disable xclient.
Similar to this commit for vhost (aka servers):
ad391f6

wyardley
wyardley approved these changes Apr 11, 2017
View reviewed changes
Copy link
Collaborator

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@vinzent vinzent added the enhancement New feature or request label Apr 11, 2017
vinzent
vinzent approved these changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@vinzent vinzent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinzent vinzent merged commit 7127e5a into voxpupuli:master Apr 11, 2017
@vinzent
Copy link
Contributor

vinzent commented Apr 11, 2017

thanks @dol !

@dol dol mentioned this pull request Apr 11, 2017
Merged
@dol
Copy link
Contributor Author

dol commented Apr 11, 2017

Thanks for the merge. 👍 🎉

@alexjfisher alexjfisher changed the title Adds hiera nginx_mailhosts_defaults like nginx_servers_defaults Add hiera nginx_mailhosts_defaults like nginx_servers_defaults Aug 1, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
@vinzent
Merge pull request voxpupuli#1068 from cyon/feature/mailhosts_defaults
7be96d6 
Adds hiera nginx_mailhosts_defaults like nginx_servers_defaults
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
@vinzent
Merge pull request voxpupuli#1068 from cyon/feature/mailhosts_defaults
fc47cab 
Adds hiera nginx_mailhosts_defaults like nginx_servers_defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyardley wyardley wyardley approved these changes

@vinzent vinzent vinzent approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dol @vinzent @wyardley